Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react-dialog): Release react-dialog stable version #25181

Merged
merged 3 commits into from
Oct 13, 2022
Merged

feat(react-dialog): Release react-dialog stable version #25181

merged 3 commits into from
Oct 13, 2022

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Oct 12, 2022 •
edited
Loading

react-dialog stable release

  1. Releases version 9.0.0 of @fluentui/react-dialog
  2. Updates stories imports from @fluentui/react-dialog to @fluentui/react-components
  3. Updates stories from Preview Components to Components
  4. Removes comments about the package being unstable
  5. re-exports @fluentui/react-dialog from @fluentui/react-components

Fixes #20953

@bsunderhus bsunderhus self-assigned this Oct 12, 2022
@bsunderhus bsunderhus force-pushed the react-dialog/release-stable branch from 9356b06 to f306c2e Compare October 12, 2022 10:42
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 12, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d3fcda:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 12, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 12222c2cfb1851ac6fbf57d17a1573432e842ec7 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 12, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme		 62.827 kB
17.599 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 189.299 kB
52.51 kB
react-components
react-components: FluentProvider & webLightTheme		 33.446 kB
11.033 kB
react-dialog
Dialog (including children components)		 82.556 kB
24.484 kB
react-portal-compat
PortalCompatProvider		 5.857 kB
1.978 kB
🤖 This report was generated against 12222c2cfb1851ac6fbf57d17a1573432e842ec7

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 12, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1245 1349 5000
Button mount 944 960 5000
FluentProvider mount 1549 1595 5000
FluentProviderWithTheme mount 637 648 10
FluentProviderWithTheme virtual-rerender 591 607 10
FluentProviderWithTheme virtual-rerender-with-unmount 637 633 10
MakeStyles mount 1920 1897 50000
SpinButton mount 2552 2492 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 12, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
FlexMinimalPerf.default 342 301 1.14:1
LayoutMinimalPerf.default 420 382 1.1:1
AttachmentMinimalPerf.default 179 165 1.08:1
LoaderMinimalPerf.default 772 717 1.08:1
PortalMinimalPerf.default 188 174 1.08:1
RefMinimalPerf.default 238 220 1.08:1
TreeWith60ListItems.default 192 177 1.08:1
AvatarMinimalPerf.default 219 208 1.05:1
ButtonSlotsPerf.default 637 609 1.05:1
ProviderMergeThemesPerf.default 1389 1320 1.05:1
SegmentMinimalPerf.default 400 381 1.05:1
SkeletonMinimalPerf.default 392 375 1.05:1
ButtonMinimalPerf.default 190 182 1.04:1
IconMinimalPerf.default 767 737 1.04:1
CustomToolbarPrototype.default 2890 2790 1.04:1
AnimationMinimalPerf.default 587 568 1.03:1
CardMinimalPerf.default 627 608 1.03:1
DropdownManyItemsPerf.default 786 761 1.03:1
TreeMinimalPerf.default 919 890 1.03:1
AlertMinimalPerf.default 304 299 1.02:1
ImageMinimalPerf.default 465 457 1.02:1
ProviderMinimalPerf.default 434 426 1.02:1
SplitButtonMinimalPerf.default 4867 4795 1.02:1
StatusMinimalPerf.default 766 753 1.02:1
TextMinimalPerf.default 380 371 1.02:1
AccordionMinimalPerf.default 168 167 1.01:1
ChatMinimalPerf.default 824 813 1.01:1
CheckboxMinimalPerf.default 2327 2315 1.01:1
DatepickerMinimalPerf.default 6379 6326 1.01:1
DialogMinimalPerf.default 856 844 1.01:1
DropdownMinimalPerf.default 2903 2874 1.01:1
InputMinimalPerf.default 1276 1259 1.01:1
ItemLayoutMinimalPerf.default 1376 1368 1.01:1
ListMinimalPerf.default 575 572 1.01:1
MenuButtonMinimalPerf.default 1943 1922 1.01:1
BoxMinimalPerf.default 361 362 1:1
HeaderMinimalPerf.default 402 402 1:1
SliderMinimalPerf.default 1745 1752 1:1
TableManyItemsPerf.default 2158 2158 1:1
ToolbarMinimalPerf.default 1071 1074 1:1
AttachmentSlotsPerf.default 1193 1206 0.99:1
ChatWithPopoverPerf.default 406 411 0.99:1
DividerMinimalPerf.default 395 398 0.99:1
ListWith60ListItems.default 684 691 0.99:1
CarouselMinimalPerf.default 500 509 0.98:1
MenuMinimalPerf.default 929 952 0.98:1
ButtonOverridesMissPerf.default 1468 1508 0.97:1
ChatDuplicateMessagesPerf.default 288 296 0.97:1
FormMinimalPerf.default 479 495 0.97:1
RadioGroupMinimalPerf.default 496 511 0.97:1
ReactionMinimalPerf.default 426 438 0.97:1
TooltipMinimalPerf.default 2527 2610 0.97:1
VideoMinimalPerf.default 806 835 0.97:1
RosterPerf.default 2432 2529 0.96:1
PopupMinimalPerf.default 677 705 0.96:1
HeaderSlotsPerf.default 899 943 0.95:1
ListCommonPerf.default 700 738 0.95:1
ListNestedPerf.default 621 655 0.95:1
EmbedMinimalPerf.default 4034 4302 0.94:1
GridMinimalPerf.default 374 408 0.92:1
LabelMinimalPerf.default 433 473 0.92:1
TableMinimalPerf.default 454 507 0.9:1
TextAreaMinimalPerf.default 550 622 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 12, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1084 1190 5000
Breadcrumb mount 2893 2671 1000
Checkbox mount 2584 2407 5000
CheckboxBase mount 2110 2246 5000
ChoiceGroup mount 4031 3958 5000
ComboBox mount 1258 1144 1000
CommandBar mount 8650 8684 1000
ContextualMenu mount 10485 10226 1000
DefaultButton mount 1312 1360 5000
DetailsRow mount 3283 3242 5000
DetailsRowFast mount 3265 3305 5000
DetailsRowNoStyles mount 3073 3059 5000
Dialog mount 3023 2746 1000
DocumentCardTitle mount 545 585 1000
Dropdown mount 3056 3023 5000
FocusTrapZone mount 1857 1833 5000
FocusZone mount 1874 1991 5000
GroupedList mount 49066 57353 2
GroupedList virtual-rerender 23240 23036 2
GroupedList virtual-rerender-with-unmount 87875 87131 2
GroupedListV2 mount 553 557 2
GroupedListV2 virtual-rerender 507 482 2
GroupedListV2 virtual-rerender-with-unmount 528 551 2
IconButton mount 1789 1832 5000
Label mount 667 650 5000
Layer mount 3994 3791 5000
Link mount 792 705 5000
MenuButton mount 1543 1659 5000
MessageBar mount 2074 2115 5000
Nav mount 2917 2978 1000
OverflowSet mount 1207 1216 5000
Panel mount 2266 2264 1000
Persona mount 1125 1144 1000
Pivot mount 1469 1492 1000
PrimaryButton mount 1340 1328 5000
Rating mount 6468 6520 5000
SearchBox mount 1457 1526 5000
Shimmer mount 2756 2673 5000
Slider mount 1883 2025 5000
SpinButton mount 4548 4144 5000
Spinner mount 780 807 5000
SplitButton mount 2768 2829 5000
Stack mount 851 775 5000
StackWithIntrinsicChildren mount 2115 2055 5000
StackWithTextChildren mount 4312 4230 5000
SwatchColorPicker mount 9738 9666 5000
TagPicker mount 2631 2377 5000
TeachingBubble mount 77953 78685 5000
Text mount 692 778 5000
TextField mount 1413 1554 5000
ThemeProvider mount 1380 1425 5000
ThemeProvider virtual-rerender 1009 1026 5000
ThemeProvider virtual-rerender-with-unmount 1923 2055 5000
Toggle mount 996 1098 5000
buttonNative mount 532 480 5000

@bsunderhus bsunderhus force-pushed the react-dialog/release-stable branch 2 times, most recently from 428b8f6 to 2740af6 Compare October 13, 2022 07:42
@bsunderhus bsunderhus marked this pull request as ready for review October 13, 2022 07:57
@bsunderhus bsunderhus requested review from a team as code owners October 13, 2022 07:57
@bsunderhus bsunderhus enabled auto-merge (squash) October 13, 2022 08:28
@bsunderhus bsunderhus force-pushed the react-dialog/release-stable branch from 8d65b55 to 4d3fcda Compare October 13, 2022 09:20
@bsunderhus bsunderhus merged commit cd05c21 into microsoft:master Oct 13, 2022
@bsunderhus bsunderhus deleted the react-dialog/release-stable branch October 13, 2022 10:11
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
@bsunderhus @layershifter @NotWoods
feat(react-dialog): Release react-dialog stable version (microsoft#…
3465111 
…25181)

* feat: react-dialog stable release

* Update packages/react-components/react-dialog/README.md

Co-authored-by: Oleksandr Fediashov <[email protected]>

* Update packages/react-components/react-dialog/README.md

Co-authored-by: Oleksandr Fediashov <[email protected]>

Co-authored-by: Oleksandr Fediashov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@layershifter layershifter layershifter approved these changes

Assignees

@bsunderhus bsunderhus

Labels
Component: Dialog
Projects
None yet
Milestone
October Project Cycle Q4 2022
Development

Successfully merging this pull request may close these issues.

Dialog
4 participants
@bsunderhus @fabricteam @layershifter @msft-fluent-ui-bot